feat(acns): Add advanced networking observability tls management for az aks create and update commands #7834

rayaisaiah · 2024-07-30T20:15:49Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Creates commands for

az aks create --advanced-networking-observability-tls-management None
az aks create --advanced-networking-observability-tls-management Managed

az aks update --advanced-networking-observability-tls-management None
az aks update --advanced-networking-observability-tls-management Managed

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-07-30T20:15:53Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter advanced_networking_observability_tls_management

⚠️ 1006 - ParaAdd aks update cmd aks update added parameter advanced_networking_observability_tls_management

azure-client-tools-bot-prd · 2024-07-30T20:15:56Z

Hi @rayaisaiah,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2024-07-30T20:15:59Z

Hi @rayaisaiah,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan · 2024-07-30T20:16:03Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2024-07-30T20:19:27Z

For more info about extension versioning, please refer to Extension version schema

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

FumingZhang

Please fix failed CI checks

https://dev.azure.com/azclitools/public/_build/results?buildId=177227&view=logs&j=506b8f13-8269-5210-246e-a3964e53141e&t=db7247cb-300d-5b59-fd6c-6258fad20b89&l=147

ERROR: /mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/_params.py:405:3: E121 continuation line under-indented for hanging indent
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:729:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:732:1: W293 blank line contains whitespace
1 E121 continuation line under-indented for hanging indent
2 W293 blank line contains whitespace

https://dev.azure.com/azclitools/public/_build/results?buildId=177227&view=logs&j=e2e497a5-ba27-5eb9-f39e-d929d56974a6&t=61cc2d02-f6f4-5007-71e9-5651933c3fe7&l=157
you can add suppression rules to src/aks-preview/linter_exclusions.yml

FAIL - HIGH severity: option_length_too_long
Parameter: aks create, advanced_networking_observability_tls_management - The lengths of all options ['--advanced-networking-observability-tls-management'] are longer than threshold 22. Argument advanced_networking_observability_tls_management must have a short abbreviation.
Parameter: aks update, advanced_networking_observability_tls_management - The lengths of all options ['--advanced-networking-observability-tls-management'] are longer than threshold 22. Argument advanced_networking_observability_tls_management must have a short abbreviation.

Add recording files for your newly added test cases.

FumingZhang · 2024-07-31T08:06:22Z

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

+        name_prefix="clitest",
+        location="eastus",
+    )
+    def test_aks_update_advanced_networking_observability_tls_management(


maybe you could combine these test cases

update with the linter errors resolved and condensed create tested under one function

FumingZhang

lgtm

Queued live test to validate the change, test passed!

test_aks_update_advanced_networking_observability_tls_management
test_aks_create_advanced_networking_observability_tls_management

FumingZhang · 2024-08-06T03:24:11Z

src/aks-preview/azext_aks_preview/_help.py

@@ -1228,6 +1228,9 @@
        - name: --disable-advanced-network-observability
          type: bool
          short-summary: Disable advanced network observability functionalities on a cluster
+        - name: --advanced-networking-observability-tls-management


This seems to be the help msg for az aks update, please also add the info for az aks create.

Updated and removed help messages in _params.py

FumingZhang · 2024-08-06T03:29:28Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

@@ -3021,7 +3028,8 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
        if advanced_network_observability is not None:
            network_profile.advanced_networking = self.models.AdvancedNetworking(  # pylint: disable=no-member


See comment about AdvancedNetworking model in #7860

Thank you for catching that updated!

FumingZhang · 2024-08-06T03:30:58Z

src/aks-preview/azext_aks_preview/_params.py

+            help=(
+                'Management of TLS certificates for querying network flow logs via the flow log endpoint.'
+                'Valid values are "Managed" and "None". If not specified, the default is Managed.'
+            )
+        )


If you've written help message in _help.py, you could omit it here.

FumingZhang · 2024-08-06T03:31:03Z

src/aks-preview/azext_aks_preview/_params.py

+            help=(
+                'Management of TLS certificates for querying network flow logs via the flow log endpoint.'
+                'Valid values are "Managed" and "None". If not specified, the default is Managed.'
+            )
+        )


If you've written help message in _help.py, you could omit it here.

… resolved other small comments

rayaisaiah · 2024-08-06T20:52:00Z

Requeued the live test pipeline to validate the updates

FumingZhang · 2024-08-07T05:42:05Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

-                    enabled=advanced_network_observability
+            # Create an advanced networking model with an observability model if it does not exist.
+            if network_profile.advanced_networking is None:
+                network_profile.advanced_networking = self.models.AdvancedNetworking(  # pylint: disable=no-member


You can just initialize the model in the if statement, and then assign values to observability outside it, so you don't have to write the same code twice

good call updated! and reran live test pipeline

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

…errate other properties

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

FumingZhang

lgtm

live test

test_aks_create_advanced_networking_observability_tls_management
test_aks_update_advanced_network_observability

FumingZhang · 2024-08-09T03:10:44Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

+            if (
+                enable_advanced_network_observability is not None and
+                enable_advanced_network_observability
+            ):


not blocking, but I think this would be enough, enable_advanced_network_observability could a bool or None and only True would meet the condition

Suggested change

if (

enable_advanced_network_observability is not None and

enable_advanced_network_observability

):

if enable_advanced_network_observability:

updated and running live test for test_aks_create_advanced_networking_observability_tls_management and
test_aks_update_advanced_network_observability

zhoxing-ms · 2024-08-13T03:30:08Z

@rayaisaiah Could you please resolve this conflict?

rayaisaiah · 2024-08-13T23:46:33Z

@rayaisaiah Could you please resolve this conflict?

updated and live test has passed for

test_aks_create_advanced_networking_observability_tls_management
test_aks_update_advanced_network_observability
test_aks_update_enable_acns
test_aks_create_with_enable_acns
test_aks_create_with_enable_acns_complex

azclibot · 2024-08-15T02:25:35Z

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=181512&view=results

inital changes adding tlsmangement to cli no tests yet

7fc846e

rayaisaiah requested review from andyliuliming and FumingZhang as code owners July 30, 2024 20:15

azure-client-tools-bot-prd bot added this to the August 2024 (2024-09-03) milestone Jul 30, 2024

microsoft-github-policy-service bot requested review from zhoxing-ms, yanzhudd and yonzhan July 30, 2024 20:16

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Jul 30, 2024

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Jul 30, 2024

rayaisaiah changed the title ~~inital changes adding tlsmangement to cli no tests yet~~ feat(acns): Add advanced networking observability tls management for az aks create and update commands Jul 30, 2024

added test cases

671d032

FumingZhang reviewed Jul 31, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Outdated Show resolved Hide resolved

FumingZhang reviewed Jul 31, 2024

View reviewed changes

rayaisaiah added 5 commits July 31, 2024 17:44

updated for styling errors

e3acc1f

merged vendored changes

797abe5

updated typo

8bdb2ca

ran azdev test

673a850

condensed create tests into one function

1c7a46f

FumingZhang reviewed Aug 6, 2024

View reviewed changes

added a condtional so the command does not overwrite advnet model and…

820ca9e

… resolved other small comments

resolved merge conflicts

7aa9f4c

snguyen64 approved these changes Aug 6, 2024

View reviewed changes

FumingZhang reviewed Aug 7, 2024

View reviewed changes

rayaisaiah requested a review from FumingZhang August 7, 2024 15:55

simplified create code and added additonal checks to update to not ov…

5186fa5

…errate other properties

rayaisaiah commented Aug 7, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Show resolved Hide resolved

rayaisaiah added 3 commits August 8, 2024 16:16

resolved merge conflicts

51b9a34

updated update function based on comments

29ea4b9

updated version

7258b90

FumingZhang reviewed Aug 9, 2024

View reviewed changes

updated based on comments

f2a37fd

rayaisaiah requested a review from FumingZhang August 9, 2024 17:38

zhoxing-ms approved these changes Aug 13, 2024

View reviewed changes

rayaisaiah added 5 commits August 13, 2024 16:32

resolved conflicts

1a78206

changed location of function

91f4781

updated functions with tls mangement

4fc8e1d

updated tests

bbd81a7

updated tests in acns

d3cc727

updated error message to include acns

869a471

zhoxing-ms merged commit 8929214 into Azure:main Aug 15, 2024
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(acns): Add advanced networking observability tls management for az aks create and update commands #7834

feat(acns): Add advanced networking observability tls management for az aks create and update commands #7834

rayaisaiah commented Jul 30, 2024

azure-client-tools-bot-prd bot commented Jul 30, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Jul 30, 2024

azure-client-tools-bot-prd bot commented Jul 30, 2024

yonzhan commented Jul 30, 2024

github-actions bot commented Jul 30, 2024 •

edited

Loading

FumingZhang left a comment

FumingZhang Jul 31, 2024

rayaisaiah Jul 31, 2024 •

edited

Loading

FumingZhang left a comment •

edited

Loading

FumingZhang Aug 6, 2024

rayaisaiah Aug 6, 2024

FumingZhang Aug 6, 2024

rayaisaiah Aug 6, 2024

FumingZhang Aug 6, 2024

FumingZhang Aug 6, 2024

rayaisaiah commented Aug 6, 2024

FumingZhang Aug 7, 2024

rayaisaiah Aug 7, 2024 •

edited

Loading

FumingZhang left a comment

FumingZhang Aug 9, 2024

rayaisaiah Aug 9, 2024

zhoxing-ms commented Aug 13, 2024

rayaisaiah commented Aug 13, 2024

azclibot commented Aug 15, 2024

		@@ -3021,7 +3028,8 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
		if advanced_network_observability is not None:
		network_profile.advanced_networking = self.models.AdvancedNetworking( # pylint: disable=no-member

feat(acns): Add advanced networking observability tls management for az aks create and update commands #7834

feat(acns): Add advanced networking observability tls management for az aks create and update commands #7834

Conversation

rayaisaiah commented Jul 30, 2024

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Jul 30, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Jul 30, 2024

azure-client-tools-bot-prd bot commented Jul 30, 2024

yonzhan commented Jul 30, 2024

github-actions bot commented Jul 30, 2024 • edited Loading

FumingZhang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rayaisaiah Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

FumingZhang left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rayaisaiah commented Aug 6, 2024

Choose a reason for hiding this comment

rayaisaiah Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

FumingZhang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhoxing-ms commented Aug 13, 2024

rayaisaiah commented Aug 13, 2024

azclibot commented Aug 15, 2024

azure-client-tools-bot-prd bot commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

rayaisaiah Jul 31, 2024 •

edited

Loading

FumingZhang left a comment •

edited

Loading

rayaisaiah Aug 7, 2024 •

edited

Loading